Added support for SSR on regions and refactored to remove handlers #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs #418 |
|
it would be useful if we also add tests in |
nunorfpt
approved these changes
Jul 11, 2018
fahad19
approved these changes
Jul 11, 2018
fahad19
reviewed
Jul 11, 2018
| @@ -7,6 +7,7 @@ import { createApp } from 'frint'; | |||
| import { observe, streamProps } from 'frint-react'; | |||
|
|
|||
| import renderToString from './renderToString'; | |||
| import Region from '../../frint-react/src/components/Region'; | |||
There was a problem hiding this comment.
if you do npm run bootstrap from root, you can import modules directly from frint-react instead of relative path within the monorepo.
|
Coverage dropped below 97%, that's why the build is failing: https://travis-ci.org/frintjs/frint/builds/402709904#L5487 |
fahad19
reviewed
Jul 12, 2018
| }, | ||
| "bugs": { | ||
| "url": "https://github.com/frintjs/frint/issues" | ||
| }, | ||
| "nyc": { |
fahad19
approved these changes
Jul 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #429 +/- ##
==========================================
+ Coverage 97.74% 97.74% +<.01%
==========================================
Files 111 112 +1
Lines 4251 4351 +100
==========================================
+ Hits 4155 4253 +98
- Misses 96 98 +2
Continue to review full report at Codecov.
|
rbardini
approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.