-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript fix: export function Region #421
Typescript fix: export function Region #421
Conversation
thanks for your valuable contribution, @andrewparadi! could you please also try something like this as mentioned in this comment? the more strict the better :) #410 (comment) we also have a placeholder issue #412 for migrating all our packages to TypeScript. if you feel like taking a stab at them, please feel free :) |
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 111 111
Lines 4251 4251
=======================================
Hits 4155 4155
Misses 96 96 Continue to review full report at Codecov.
|
Thanks for the heads up to those issues @fahad19, I'll plan to make other PRs under #412 as I come across any other Typescript issues in the weeks to come as I work on our new FrintJS app. A huge thank you already for FrintJS, exactly what we've been searching for, very thankful I stumbled upon it instead of having to try and build it all from scratch. Once it's ready to merge, let me know and I can squash the commits with rebase. |
Commit squashed and ready for merge if no other changes are requested. |
@frintjs/core: please take a look and approve :D |
@leandrooriente: please let me know if you would be willing to merge and release a new patch version. |
I started working on a FrintJS app using the
multiple-apps
as starter code. I began by moving the repo to Typescript and encountered this persistent error inRoot.jsx
when Region is imported.To fix this, Region is added as an export to the index definition file and the error no longer appears.
I'm still early in my Typescript days so if this isn't the best way to resolve the error, please comment below.