Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new theme #33

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Update to new theme #33

merged 4 commits into from
Nov 21, 2024

Conversation

shannonwells
Copy link

@shannonwells shannonwells commented Nov 20, 2024

Goal

The goal of this PR is to make the site look like the rest of the Developer Portal.
To do this, the Style Guide was added so that the custom Tailwind styles and some of the Style Guide components can be used.

I used the Figma docs as a guide for whitespace, font sizes, and media break changes. I tried to make it work at even very small widths, < 400px.

Closes #32

Checklist

  • PR Self-Review and Commenting

How To Test the Changes

check on multiple browsers at http://localhost:5173 :

git fetch && git checkout theme-update
cd client
npm run dev

<footer
class="sm md:md mx-auto my-0 flex max-w-screen-xl flex-col items-center gap-f16 border-t-[2px] border-current py-f48 md:gap-f48 {fgColorText}"
>
<FrequencyLogo fill="#000000"/>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to match the frequency.xyz site, however the link to the privacy policy would point to the faucet, not frequency.xyz, so I just copied the code & modified it, then converted the logo SVG to a Svelte component to let you make a resizable, colored one.

@shannonwells shannonwells marked this pull request as ready for review November 21, 2024 01:05
@shannonwells shannonwells enabled auto-merge (squash) November 21, 2024 01:07
@shannonwells shannonwells marked this pull request as draft November 21, 2024 20:28
Copy link

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read code & pair programmed & pair reviewed 🚢

@shannonwells shannonwells marked this pull request as ready for review November 21, 2024 22:36
@shannonwells shannonwells merged commit 5aa6681 into main Nov 21, 2024
6 checks passed
@shannonwells shannonwells deleted the theme-update branch November 21, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Faucet Styles and Links
2 participants