fix yarn run build, Docker build #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonwells
commented
Sep 18, 2024
| @@ -214,7 +214,7 @@ describe("Faucet E2E", () => { | |||
|
|
|||
| const oldDrip = new Drip(); | |||
| oldDrip.addressSha256 = sha256(userAddress); | |||
| oldDrip.timestamp = BigInt(Date.now() - 30 * 60 * 60 * 1000); | |||
| oldDrip.timestamp = Date.now() - 30 * 60 * 60 * 1000; | |||
There was a problem hiding this comment.
tsc whines about this. We don't run e2e tests anyway, they are horribly broken
shannonwells
commented
Sep 18, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "baseUrl": ".", | |||
| "baseUrl": "./", | |||
There was a problem hiding this comment.
I put this back to what it was originally just to see if that was part of the problem, and I figured why not leave it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker build was broken because the top level
yarn run buildwas broken. It looks like it was because of this problem which keeps coming up: LeDDGroup/typescript-transform-paths#266yarn run buildstep to verify-pr workflow. I'm keeping these as separate checkout and run steps because they are also built separately on a merge and deployed in different places.