Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

27 form input #34

Merged
merged 4 commits into from
Oct 25, 2024
Merged

27 form input #34

merged 4 commits into from
Oct 25, 2024

Conversation

claireolmstead
Copy link
Collaborator

Problem

Need a form input and story

closes #27

Solution

  • create form input and story

Steps to Verify:

  1. check story

Screenshots (optional):

Screen.Recording.2024-10-24.at.2.27.01.PM.mov

@claireolmstead claireolmstead self-assigned this Oct 24, 2024
@claireolmstead claireolmstead linked an issue Oct 24, 2024 that may be closed by this pull request
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Select option" and "Please choose an option" labels used for the Input stories is confusing. When I saw it I expected a dropdown but it's not a <select> it's just a plain input.

@claireolmstead
Copy link
Collaborator Author

The "Select option" and "Please choose an option" labels used for the Input stories is confusing. When I saw it I expected a dropdown but it's not a <select> it's just a plain input.

@shannonwells whoops! A little copy paste leftover. Fixed ✅

@claireolmstead claireolmstead merged commit 7c53cd4 into main Oct 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form: Input
2 participants