Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 desktop header navigation #31

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

claireclark1
Copy link
Collaborator

@claireclark1 claireclark1 commented Oct 18, 2024

Problem

Desktop and Mobile header and navigation.

closes #10
closes #5

Solution

Added mobile and desktop header and navigation components and stories

Steps to Verify:

  1. run storybook to make sure it looks good
  2. read through code to make sure it is scalable and has all of the functionality that we could want.

Screenshots (optional):

Screen.Recording.2024-10-18.at.1.51.03.PM.mov

@claireclark1 claireclark1 self-assigned this Oct 18, 2024
@claireclark1 claireclark1 linked an issue Oct 18, 2024 that may be closed by this pull request
@claireclark1 claireclark1 mentioned this pull request Oct 18, 2024
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I downloaded the branch, ran storybook and looked at both mobile and desktop views.

Copy link
Contributor

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran storybook & inspected on both desktop & mobile. Nice work!

@claireclark1 claireclark1 merged commit 32ea40b into main Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Desktop Header & Navigation Mobile Navigation
3 participants