style: new hover effect on all buttons #4411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Forhåndsvisning: https://jokul.fremtind.no/preview/olejorgenbakken/issue4276/ Forhåndsvisningen blir tilgjengelig innen et par minutter. Den fjernes automatisk når pull requesten lukkes. |
fremtind-bot
added a commit
that referenced
this pull request
Jan 8, 2025
fremtind-bot
added a commit
that referenced
this pull request
Jan 8, 2025
fremtind-bot
added a commit
that referenced
this pull request
Jan 8, 2025
fremtind-bot
added a commit
that referenced
this pull request
Jan 8, 2025
|
Jeg skjønner rationalet for å prøve å lage noe som funker for alle komponenter men kanskje vi burde åpne for å være litt pragmatiske og spesialhåndtere de tilfellene der det ikke fungerer så godt, slik vi gjorde for fokus? |
olejorgenbakken
requested review from
piofinn,
ivarni,
zenabii and
a team
and removed request for
piofinn
fremtind-bot
added a commit
that referenced
this pull request
Jan 9, 2025
piofinn
previously approved these changes
Jan 9, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to invalid changes in the merge commit
github-merge-queue
bot
removed this pull request from the merge queue due to invalid changes in the merge commit
github-merge-queue
bot
removed this pull request from the merge queue due to invalid changes in the merge commit
fremtind-bot
added a commit
that referenced
this pull request
Jan 13, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to invalid changes in the merge commit
olejorgenbakken
force-pushed
the
olejorgenbakken/issue4276
branch
from
187fde8 to
6e8816c
Compare
fremtind-bot
added a commit
that referenced
this pull request
Jan 14, 2025
fremtind-bot
added a commit
that referenced
this pull request
Jan 14, 2025
ivarni
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #4276
Jeg har satt opp et forslag på ny hover effekt basert på chip sin hover. En ting jeg, @piofinn og @fremtindjonas diskuterte er hvorvidt den er tydelig nok på primary varianten. Noe å diskutere muligens?