Skip to content

Commit

Permalink
mobile: Remove unused extension function (envoyproxy#30237)
Browse files Browse the repository at this point in the history
`EngineBuilder.enableHttp3` extension function shadows
`EngineBuilder.enableHttp3(Boolean)`, which means it will never be used
due to the way extension functions work and it also does the same thing
as `EngineBuilder.enableHttp3(Boolean)`.

The warning:
```
library/kotlin/io/envoyproxy/envoymobile/EngineBuilderHTTP3Util.kt:13:21:
warning: extension is shadowed by a member: public final fun enableHttp3(enableHttp3: Boolean): EngineBuilder
fun EngineBuilder.enableHttp3(doEnableHttp3: Boolean): EngineBuilder {
```

Signed-off-by: Fredy Wijaya <[email protected]>
  • Loading branch information
fredyw authored Oct 16, 2023
1 parent 8d733bf commit 091ca54
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
3 changes: 0 additions & 3 deletions mobile/library/kotlin/io/envoyproxy/envoymobile/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ envoy_mobile_kt_library(
"RequestHeadersBuilderCompressionUtil.kt",
],
"@envoy",
) + envoy_select_enable_http3(
["EngineBuilderHTTP3Util.kt"],
"@envoy",
),
visibility = ["//visibility:public"],
deps = [
Expand Down

This file was deleted.

0 comments on commit 091ca54

Please sign in to comment.