Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip app cache for non frappe #1459

Merged
merged 2 commits into from
Feb 21, 2024
Merged

fix: skip app cache for non frappe #1459

merged 2 commits into from
Feb 21, 2024

Conversation

18alantom
Copy link
Member

@18alantom 18alantom commented Feb 21, 2024

A change in Bench's build dependency has cause bench deploys to break. Until a new bench version can be released, I'll be skipping cache for non frappe apps.

@18alantom 18alantom enabled auto-merge February 21, 2024 12:54
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4be84c3) 45.37% compared to head (f82eebc) 45.38%.
Report is 29 commits behind head on master.

❗ Current head f82eebc differs from pull request most recent head 96bd261. Consider uploading reports for the commit 96bd261 to get more accurate results

Files Patch % Lines
...press/doctype/deploy_candidate/deploy_candidate.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1459   +/-   ##
=======================================
  Coverage   45.37%   45.38%           
=======================================
  Files         312      312           
  Lines       21010    21011    +1     
=======================================
+ Hits         9534     9535    +1     
  Misses      11476    11476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@18alantom 18alantom disabled auto-merge February 21, 2024 13:19
@18alantom
Copy link
Member Author

Ignoring codecov.

@18alantom 18alantom merged commit 923166a into master Feb 21, 2024
4 checks passed
@18alantom 18alantom deleted the skip-cache-non-frappe branch February 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant