Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc issues #1251

Merged
merged 4 commits into from
Jan 16, 2025
Merged

fix: misc issues #1251

merged 4 commits into from
Jan 16, 2025

Conversation

pateljannat
Copy link
Collaborator

@pateljannat pateljannat commented Jan 16, 2025 •
edited
Loading

  1. If a batch starts today, it should be visible in the upcoming section until the start time and then be archived.
  2. Fixed the favicon for the portal
  3. Course is now no longer mandatory to generate a certificate. Certification is too linked to courses #1250

@cypress Cypress
Copy link

cypress bot commented Jan 16, 2025 •
edited
Loading

lms    Run #983

Run Properties:  status check passed Passed #983  •  git commit 7a05bead09 ℹ️: Merge 5a6fdfcbc39a80b57c81dc2cd1f0a7a549e9606d into 0d1464c5e9c64cc7e6f35346b4e0...
Project lms
Branch Review issues-67
Run status status check passed Passed #983
Run duration 00m 29s
Commit git commit 7a05bead09 ℹ️: Merge 5a6fdfcbc39a80b57c81dc2cd1f0a7a549e9606d into 0d1464c5e9c64cc7e6f35346b4e0...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 7acc186 into frappe:develop Jan 16, 2025
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @frappe-pr-bot