refactor: improved performance and ui batch list #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lms
|
||||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
batch-refactor
|
| Run status |
|
| Run duration | 00m 30s |
| Commit |
|
| Committer | Jannat Patel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
|
🎉 This PR is included in version 2.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of the batch list was not good for scale. Now with time, as most platforms have too many batches, loading them all slowed down the system. The previous design also restricted the improvements.
This PR refactors the entire batch list both for performance and UI. There are better filters on the page that load data accordingly ensuring that the system is not loaded.
batches.mp4