Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed delivery parameter from batch feedback #1244

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix: removed delivery parameter from batch feedback #1244

merged 1 commit into from
Jan 14, 2025
+35 −48

Conversation

pateljannat
Copy link
Collaborator

  1. Batch Feedback will have parameters for Content, Instructor, and Value. It will no longer have the delivery parameter.
  2. Before saving the profile bio, sanitized its value to escape scripts.

@cypress Cypress
Copy link

cypress bot commented Jan 14, 2025

lms    Run #971

Run Properties:  status check passed Passed #971  •  git commit 7740ac55e7 ℹ️: Merge 61e41180ddcccdb919cf3fd2359052ceeedf4af1 into 9a395cbda0c0de7bc0df2d66ffb6...
Project lms
Branch Review issues-65
Run status status check passed Passed #971
Run duration 00m 38s
Commit git commit 7740ac55e7 ℹ️: Merge 61e41180ddcccdb919cf3fd2359052ceeedf4af1 into 9a395cbda0c0de7bc0df2d66ffb6...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 6020d5f into frappe:develop Jan 14, 2025
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.20.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @frappe-pr-bot