Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misc batch issues #1226

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: misc batch issues #1226

merged 1 commit into from
Jan 3, 2025

Conversation

pateljannat
Copy link
Collaborator

  1. Fixes Case when batch enrolment happens after live class is already created #1225
  2. Fixes Disable / Show "Ended" on Live classes that have already passed  #1217
  3. Progress percentage will now be visible in batches on the students' list. The list will be sorted based on descending order of progress.

Copy link

cypress bot commented Jan 3, 2025

lms    Run #948

Run Properties:  status check passed Passed #948  •  git commit c79fbc7f24 ℹ️: Merge f77686feaa3e921f6cd1250756eec6a6e6ae2853 into 34548b93f48239e72589bf6842a0...
Project lms
Branch Review issues-61
Run status status check passed Passed #948
Run duration 00m 29s
Commit git commit c79fbc7f24 ℹ️: Merge f77686feaa3e921f6cd1250756eec6a6e6ae2853 into 34548b93f48239e72589bf6842a0...
Committer Jannat Patel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit 4759736 into frappe:develop Jan 3, 2025
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants