Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attachments #2092

Merged
merged 9 commits into from
Dec 18, 2024
Merged

fix: attachments #2092

merged 9 commits into from
Dec 18, 2024

Conversation

RitvikSardana
Copy link
Member

@RitvikSardana RitvikSardana commented Dec 17, 2024

Issue:

  1. When a ticket was created users attachment were not showing, this is because attachments object was not being passed.
  2. When an agent attached a file that file becomes private and the customer is not able to access it.

Solution:

  1. Attach tickets object while creating ticket.
  2. Attach the file uploaded to the ticket, to share its access with the customers having access to the tickets.

@RitvikSardana RitvikSardana changed the title fix: on ticket creation attachments were not being linked. fix: attachments Dec 17, 2024
@RitvikSardana RitvikSardana merged commit b83dcb3 into frappe:develop Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant