Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attach attachments after the ticket is saved #1715

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

niraj2477
Copy link
Contributor

@niraj2477 niraj2477 commented Mar 6, 2024

Issue:

When we upload an attachment in ticket doctype as parameter is passed, which will breaks the file upload
https://github.com/frappe/frappe/blob/develop/frappe/core/doctype/file/file.py#L140

Solution:

While uploading attachments, we do not need to pass the doctype parameter, it will be automatically handled by create_communication_via_contact method

issue ref: #1695 ,#1712

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.59%. Comparing base (50a98ca) to head (8800411).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1715   +/-   ##
=====================================
  Coverage   2.59%   2.59%           
=====================================
  Files         59      59           
  Lines       1926    1926           
=====================================
  Hits          50      50           
  Misses      1876    1876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niraj2477
Copy link
Contributor Author

niraj2477 commented Mar 6, 2024

@sumitbhanushali Can you have a look at this? As we are not able to upload the attachment because of this.
Let me know if you have any other approach for the same

@sumitbhanushali sumitbhanushali merged commit 4b56aae into frappe:main Mar 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants