fix: Attach attachments after the ticket is saved #1715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When we upload an attachment in ticket
doctype
as parameter is passed, which will breaks the file uploadhttps://github.com/frappe/frappe/blob/develop/frappe/core/doctype/file/file.py#L140
Solution:
While uploading attachments, we do not need to pass the
doctype
parameter, it will be automatically handled bycreate_communication_via_contact
methodissue ref: #1695 ,#1712