Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show comment in email #1658

Merged
merged 3 commits into from
Dec 22, 2023
Merged

fix: show comment in email #1658

merged 3 commits into from
Dec 22, 2023

Conversation

shadrak98
Copy link
Collaborator

@shadrak98 shadrak98 commented Dec 21, 2023

Fixes #1655

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e2dcc7f) 2.56% compared to head (6215873) 2.55%.
Report is 10 commits behind head on main.

Files Patch % Lines
...elpdesk/doctype/hd_notification/hd_notification.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1658      +/-   ##
========================================
- Coverage   2.56%   2.55%   -0.02%     
========================================
  Files         59      59              
  Lines       1912    1920       +8     
========================================
  Hits          49      49              
- Misses      1863    1871       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shadrak98 shadrak98 merged commit fa355b5 into frappe:main Dec 22, 2023
6 of 8 checks passed
@shadrak98 shadrak98 deleted the fix-mentions branch December 22, 2023 06:37
@ankush
Copy link
Member

ankush commented Mar 4, 2024

@shadrak98

#1714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show comment in notification email itself
2 participants