Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change Resolve btn to 'Resolve and Close' on portal #1645

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

shadrak98
Copy link
Collaborator

On Resolve and Close, change the status to close

Screencast.from.06-12-23.01.07.24.PM.IST.webm

On Resolve and Close, change the status to close
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (2d07252) 2.51% compared to head (6546bc8) 2.56%.
Report is 23 commits behind head on main.

❗ Current head 6546bc8 differs from pull request most recent head 3323b6a. Consider uploading reports for the commit 3323b6a to get more accurate results

Files Patch % Lines
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 0.00% 21 Missing ⚠️
helpdesk/helpdesk/doctype/hd_ticket/api.py 0.00% 10 Missing ⚠️
...vice_level_agreement/hd_service_level_agreement.py 0.00% 3 Missing ⚠️
helpdesk/utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1645      +/-   ##
========================================
+ Coverage   2.51%   2.56%   +0.04%     
========================================
  Files         59      59              
  Lines       1908    1912       +4     
========================================
+ Hits          48      49       +1     
- Misses      1860    1863       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankush ankush changed the title fix!: change Resolve btn to 'Resolve and Close' on portal fix: change Resolve btn to 'Resolve and Close' on portal Dec 12, 2023
@ankush ankush merged commit 15d849a into frappe:main Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants