Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): set first response at even without replied status #1605

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Oct 23, 2023

No description provided.

@ssiyad ssiyad force-pushed the fix/ux/first_responded_on branch from 80230a7 to 63333c3 Compare October 23, 2023 06:45
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Files Coverage Δ
helpdesk/utils.py 0.00% <0.00%> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 0.00% <0.00%> (ø)
helpdesk/helpdesk/doctype/hd_ticket/api.py 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

@ssiyad ssiyad added the bug-fix label Oct 23, 2023
@ssiyad ssiyad merged commit 2da9503 into frappe:main Oct 23, 2023
6 of 8 checks passed
@ssiyad ssiyad deleted the fix/ux/first_responded_on branch October 23, 2023 06:52
ssiyad added a commit to ssiyad/helpdesk that referenced this pull request Oct 23, 2023
ssiyad added a commit that referenced this pull request Oct 23, 2023
* patch(ticket): first response from communication

This used to be set from `Replied` status. The logic is then changed to
fetch first response from communication instead

* Revert "fix(ux): set first response at even without `replied` status (#1605)"

This reverts commit 2da9503.

* fix(ux): set first response on `Replied`

* fix: fetch value directly and avoid update where applicable

---------

Co-authored-by: Ankush Menat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant