Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: share why condition is wrong #1597

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: share why condition is wrong #1597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helpdesk/helpdesk/doctype/hd_service_level_agreement/hd_service_level_agreement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@
try:
temp_doc = frappe.new_doc(self.document_type)
frappe.safe_eval(self.condition, None, get_context(temp_doc))
except Exception:
frappe.throw(_("The Condition '{0}' is invalid").format(self.condition))
except Exception as e:
frappe.throw(_("The Condition '{0}' is invalid: {1}").format(self.condition, str(e)))

Check failure on line 99 in helpdesk/helpdesk/doctype/hd_service_level_agreement/hd_service_level_agreement.py

View workflow job for this annotation

GitHub Actions / Black - Reviewdog 

[black-format] reported by reviewdog 🐶


Raw Output:
helpdesk/helpdesk/doctype/hd_service_level_agreement/hd_service_level_agreement.py:99:-			frappe.throw(_("The Condition '{0}' is invalid: {1}").format(self.condition, str(e)))
helpdesk/helpdesk/doctype/hd_service_level_agreement/hd_service_level_agreement.py:99:+			frappe.throw(
helpdesk/helpdesk/doctype/hd_service_level_agreement/hd_service_level_agreement.py:100:+				_("The Condition '{0}' is invalid: {1}").format(self.condition, str(e))
helpdesk/helpdesk/doctype/hd_service_level_agreement/hd_service_level_agreement.py:101:+			)

# What?
def get_hd_service_level_agreement_priority(self, priority):
Expand Down
Loading