chore: handle if sla does not exist

helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py

@@ -718,15 +718,13 @@ def set_sla(self):
 		"""
 		if sla := get_sla(self):
 			self.sla = sla.name
-		self.sla = None
 
 	def apply_sla(self):
 		"""
-		Apply SLA if set. This won't check whether the SLA exists. Hence, will
-		fail/error if the SLA is deleted.
+		Apply SLA if set.
 		"""
-		if self.sla:
-			frappe.get_doc("HD Service Level Agreement", self.sla).apply(self)
+		if sla := frappe.get_last_doc("HD Service Level Agreement", {"name": self.sla}):
+			sla.apply(self)
 
 	# `on_communication_update` is a special method exposed from `Communication` doctype.
 	# It is called when a communication is updated. Beware of changes as this effectively

helpdesk/utils.py

@@ -22,6 +22,17 @@ def check_permissions(doctype, parent):
 		frappe.throw(f"Insufficient Permission for {doctype}", frappe.PermissionError)
 
 
+def is_admin(user: str = None) -> bool:
+	"""
+	Check whether `user` is an admin
+
+	:param user: User to check against, defaults to current user
+	:return: Whether `user` is an admin
+	"""
+	user = user or frappe.session.user
+	return user == "Administrator"
+
+
 def is_agent(user: str = None) -> bool:
 	"""
 	Check whether `user` is an agent
@@ -30,7 +41,7 @@ def is_agent(user: str = None) -> bool:
 	:return: Whether `user` is an agent
 	"""
 	user = user or frappe.session.user
-	return bool(frappe.db.exists("HD Agent", {"name": user}))
+	return is_admin() or bool(frappe.db.exists("HD Agent", {"name": user}))
 
 
 def publish_event(event: str, data: dict, user: str = None):