Refactor ticket agent list, filter, sort #648
lint.yml
on: pull_request
Semantic Commits
16s
ESLint - Reviewdog
41s
Black - Reviewdog
13s
Semgrep Rules
23s
Annotations
20 errors and 9 warnings
Black - Reviewdog:
helpdesk/api/doc.py#L75
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:75:+
|
Black - Reviewdog:
helpdesk/api/doc.py#L76
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:76:-def get_list_data(doctype: str, filters: dict, order_by: str, page_length=20, page_length_count=20,):
helpdesk/api/doc.py:77:+def get_list_data(
helpdesk/api/doc.py:78:+ doctype: str,
helpdesk/api/doc.py:79:+ filters: dict,
helpdesk/api/doc.py:80:+ order_by: str,
helpdesk/api/doc.py:81:+ page_length=20,
helpdesk/api/doc.py:82:+ page_length_count=20,
helpdesk/api/doc.py:83:+):
|
Black - Reviewdog:
helpdesk/api/doc.py#L79
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:79:- {"label": "Last Modified", "type": "Datetime", "key": "modified", "width": "8rem"},
helpdesk/api/doc.py:86:+ {
helpdesk/api/doc.py:87:+ "label": "Last Modified",
helpdesk/api/doc.py:88:+ "type": "Datetime",
helpdesk/api/doc.py:89:+ "key": "modified",
helpdesk/api/doc.py:90:+ "width": "8rem",
helpdesk/api/doc.py:91:+ },
|
Black - Reviewdog:
helpdesk/api/doc.py#L102
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:102:- data = frappe.get_all(
helpdesk/api/doc.py:103:- doctype,
helpdesk/api/doc.py:104:- fields=rows,
helpdesk/api/doc.py:105:- filters=filters,
helpdesk/api/doc.py:106:- order_by=order_by,
helpdesk/api/doc.py:107:- page_length=page_length,
helpdesk/api/doc.py:108:- ) or []
helpdesk/api/doc.py:114:+ data = (
helpdesk/api/doc.py:115:+ frappe.get_all(
helpdesk/api/doc.py:116:+ doctype,
helpdesk/api/doc.py:117:+ fields=rows,
helpdesk/api/doc.py:118:+ filters=filters,
helpdesk/api/doc.py:119:+ order_by=order_by,
helpdesk/api/doc.py:120:+ page_length=page_length,
helpdesk/api/doc.py:121:+ )
helpdesk/api/doc.py:122:+ or []
helpdesk/api/doc.py:123:+ )
|
Black - Reviewdog:
helpdesk/api/doc.py#L138
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:138:- if field.get('value') not in rows:
helpdesk/api/doc.py:139:- rows.append(field.get('value'))
helpdesk/api/doc.py:153:+ if field.get("value") not in rows:
helpdesk/api/doc.py:154:+ rows.append(field.get("value"))
|
Black - Reviewdog:
helpdesk/api/doc.py#L153
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:168:+
|
Black - Reviewdog:
helpdesk/api/doc.py#L178
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:178:- return fields
helpdesk/api/doc.py:194:+ return fields
|
Black - Reviewdog:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py#L683
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:683:-
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:683:+
|
Black - Reviewdog:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py#L689
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:689:- 'label': '#',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:690:- 'type': 'Int',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:691:- 'key': 'name',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:692:- 'width': '5rem',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:693:- },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:694:- {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:695:- 'label': 'Subject',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:696:- 'type': 'Data',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:697:- 'key': 'subject',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:698:- 'width': '25rem',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:699:- },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:700:- {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:701:- 'label': 'Status',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:702:- 'type': 'Select',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:703:- 'key': 'status',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:704:- 'width': '8rem',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:705:- },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:706:- {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:707:- 'label': 'Priority',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:708:- 'type': 'Link',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:709:- 'options': 'HD Ticket Priority',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:710:- 'key': 'priority',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:711:- 'width': '10rem',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:712:- },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:713:- {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:714:- 'label': 'Type',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:715:- 'type': 'Link',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:689:+ "label": "#",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:690:+ "type": "Int",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:691:+ "key": "name",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:692:+ "width": "5rem",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:693:+ },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:694:+ {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:695:+ "label": "Subject",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:696:+ "type": "Data",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:697:+ "key": "subject",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:698:+ "width": "25rem",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:699:+ },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:700:+ {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:701:+ "label": "Status",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:702:+ "type": "Select",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:703:+ "key": "status",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:704:+ "width": "8rem",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:705:+ },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:706:+ {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:707:+ "label": "Priority",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:708:+ "type": "Link",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:709:+ "options": "HD Ticket Priority",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:710:+ "key": "priority",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:711:+ "width": "10rem",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:712:+ },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:713:+ {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:714:+ "label": "Type",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:715:+ "type": "Link",
|
Black - Reviewdog
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L195
[eslint] reported by reviewdog 🐶
Don't use `Function` as a type. The `Function` type accepts any function-like value.
It provides no type safety when calling the function, which can be a common source of bugs.
It also accepts things like class declarations, which will throw at runtime as they will not be called with `new`.
If you are expecting the function to accept certain arguments, you should explicitly define the function shape.
Raw Output:
{"ruleId":"@typescript-eslint/ban-types","severity":2,"message":"Don't use `Function` as a type. The `Function` type accepts any function-like value.\nIt provides no type safety when calling the function, which can be a common source of bugs.\nIt also accepts things like class declarations, which will throw at runtime as they will not be called with `new`.\nIf you are expecting the function to accept certain arguments, you should explicitly define the function shape.","line":195,"column":29,"nodeType":"Identifier","messageId":"bannedTypeMessage","endLine":195,"endColumn":37}
|
ESLint - Reviewdog:
desk/src/components/Sort.vue#L158
[eslint] reported by reviewdog 🐶
Don't use `Function` as a type. The `Function` type accepts any function-like value.
It provides no type safety when calling the function, which can be a common source of bugs.
It also accepts things like class declarations, which will throw at runtime as they will not be called with `new`.
If you are expecting the function to accept certain arguments, you should explicitly define the function shape.
Raw Output:
{"ruleId":"@typescript-eslint/ban-types","severity":2,"message":"Don't use `Function` as a type. The `Function` type accepts any function-like value.\nIt provides no type safety when calling the function, which can be a common source of bugs.\nIt also accepts things like class declarations, which will throw at runtime as they will not be called with `new`.\nIf you are expecting the function to accept certain arguments, you should explicitly define the function shape.","line":158,"column":27,"nodeType":"Identifier","messageId":"bannedTypeMessage","endLine":158,"endColumn":35}
|
ESLint - Reviewdog:
desk/src/components/icons/FilterIcon.vue#L2
[eslint] reported by reviewdog 🐶
Delete `··`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Delete `··`","line":2,"column":3,"nodeType":null,"messageId":"delete","endLine":2,"endColumn":5,"fix":{"range":[13,15],"text":""}}
|
ESLint - Reviewdog:
desk/src/components/icons/FilterIcon.vue#L3
[eslint] reported by reviewdog 🐶
Delete `··`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Delete `··`","line":3,"column":1,"nodeType":null,"messageId":"delete","endLine":3,"endColumn":3,"fix":{"range":[20,22],"text":""}}
|
ESLint - Reviewdog
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
ESLint - Reviewdog:
desk/src/components/icons/FilterIcon.vue#L4
[eslint] reported by reviewdog 🐶
Delete `··`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Delete `··`","line":4,"column":5,"nodeType":null,"messageId":"delete","endLine":4,"endColumn":7,"fix":{"range":[41,43],"text":""}}
|
ESLint - Reviewdog:
desk/src/components/icons/FilterIcon.vue#L5
[eslint] reported by reviewdog 🐶
Delete `··`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Delete `··`","line":5,"column":1,"nodeType":null,"messageId":"delete","endLine":5,"endColumn":3,"fix":{"range":[55,57],"text":""}}
|
ESLint - Reviewdog:
desk/src/components/icons/FilterIcon.vue#L6
[eslint] reported by reviewdog 🐶
Delete `··`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Delete `··`","line":6,"column":5,"nodeType":null,"messageId":"delete","endLine":6,"endColumn":7,"fix":{"range":[85,87],"text":""}}
|
ESLint - Reviewdog:
desk/src/components/icons/FilterIcon.vue#L7
[eslint] reported by reviewdog 🐶
Delete `··`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Delete `··`","line":7,"column":1,"nodeType":null,"messageId":"delete","endLine":7,"endColumn":3,"fix":{"range":[99,101],"text":""}}
|
ESLint - Reviewdog:
desk/src/components/icons/FilterIcon.vue#L8
[eslint] reported by reviewdog 🐶
Delete `··`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Delete `··`","line":8,"column":3,"nodeType":null,"messageId":"delete","endLine":8,"endColumn":5,"fix":{"range":[142,144],"text":""}}
|
Semantic Commits
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Black - Reviewdog
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Semgrep Rules
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
ESLint - Reviewdog:
desk/src/components/ViewControls.vue#L63
[eslint] reported by reviewdog 🐶
'e' is defined but never used.
Raw Output:
{"ruleId":"@typescript-eslint/no-unused-vars","severity":1,"message":"'e' is defined but never used.","line":63,"column":15,"nodeType":"Identifier","messageId":"unusedVar","endLine":63,"endColumn":16}
|
ESLint - Reviewdog:
desk/src/components/ViewControls.vue#L74
[eslint] reported by reviewdog 🐶
'e' is defined but never used.
Raw Output:
{"ruleId":"@typescript-eslint/no-unused-vars","severity":1,"message":"'e' is defined but never used.","line":74,"column":15,"nodeType":"Identifier","messageId":"unusedVar","endLine":74,"endColumn":16}
|
ESLint - Reviewdog:
desk/src/components/ViewControls.vue#L87
[eslint] reported by reviewdog 🐶
'e' is defined but never used.
Raw Output:
{"ruleId":"@typescript-eslint/no-unused-vars","severity":1,"message":"'e' is defined but never used.","line":87,"column":15,"nodeType":"Identifier","messageId":"unusedVar","endLine":87,"endColumn":16}
|
ESLint - Reviewdog:
desk/src/components/ViewControls.vue#L100
[eslint] reported by reviewdog 🐶
'e' is defined but never used.
Raw Output:
{"ruleId":"@typescript-eslint/no-unused-vars","severity":1,"message":"'e' is defined but never used.","line":100,"column":15,"nodeType":"Identifier","messageId":"unusedVar","endLine":100,"endColumn":16}
|
ESLint - Reviewdog:
desk/src/components/ViewControls.vue#L113
[eslint] reported by reviewdog 🐶
'e' is defined but never used.
Raw Output:
{"ruleId":"@typescript-eslint/no-unused-vars","severity":1,"message":"'e' is defined but never used.","line":113,"column":15,"nodeType":"Identifier","messageId":"unusedVar","endLine":113,"endColumn":16}
|
ESLint - Reviewdog
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3, actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|