Refactor ticket agent list, filter, sort #646
lint.yml
on: pull_request
Semantic Commits
15s
ESLint - Reviewdog
43s
Black - Reviewdog
13s
Semgrep Rules
23s
Annotations
20 errors and 13 warnings
Black - Reviewdog:
helpdesk/api/doc.py#L75
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:75:+
|
Black - Reviewdog:
helpdesk/api/doc.py#L76
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:76:-def get_list_data(doctype: str, filters: dict, order_by: str, page_length=20, page_length_count=20,):
helpdesk/api/doc.py:77:+def get_list_data(
helpdesk/api/doc.py:78:+ doctype: str,
helpdesk/api/doc.py:79:+ filters: dict,
helpdesk/api/doc.py:80:+ order_by: str,
helpdesk/api/doc.py:81:+ page_length=20,
helpdesk/api/doc.py:82:+ page_length_count=20,
helpdesk/api/doc.py:83:+):
|
Black - Reviewdog:
helpdesk/api/doc.py#L79
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:79:- {"label": "Last Modified", "type": "Datetime", "key": "modified", "width": "8rem"},
helpdesk/api/doc.py:86:+ {
helpdesk/api/doc.py:87:+ "label": "Last Modified",
helpdesk/api/doc.py:88:+ "type": "Datetime",
helpdesk/api/doc.py:89:+ "key": "modified",
helpdesk/api/doc.py:90:+ "width": "8rem",
helpdesk/api/doc.py:91:+ },
|
Black - Reviewdog:
helpdesk/api/doc.py#L102
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:102:- data = frappe.get_all(
helpdesk/api/doc.py:103:- doctype,
helpdesk/api/doc.py:104:- fields=rows,
helpdesk/api/doc.py:105:- filters=filters,
helpdesk/api/doc.py:106:- order_by=order_by,
helpdesk/api/doc.py:107:- page_length=page_length,
helpdesk/api/doc.py:108:- ) or []
helpdesk/api/doc.py:114:+ data = (
helpdesk/api/doc.py:115:+ frappe.get_all(
helpdesk/api/doc.py:116:+ doctype,
helpdesk/api/doc.py:117:+ fields=rows,
helpdesk/api/doc.py:118:+ filters=filters,
helpdesk/api/doc.py:119:+ order_by=order_by,
helpdesk/api/doc.py:120:+ page_length=page_length,
helpdesk/api/doc.py:121:+ )
helpdesk/api/doc.py:122:+ or []
helpdesk/api/doc.py:123:+ )
|
Black - Reviewdog:
helpdesk/api/doc.py#L138
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/api/doc.py:138:- if field.get('value') not in rows:
helpdesk/api/doc.py:139:- rows.append(field.get('value'))
helpdesk/api/doc.py:153:+ if field.get("value") not in rows:
helpdesk/api/doc.py:154:+ rows.append(field.get("value"))
|
Black - Reviewdog:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py#L683
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:683:-
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:683:+
|
Black - Reviewdog:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py#L689
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:689:- 'label': '#',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:690:- 'type': 'Int',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:691:- 'key': 'name',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:692:- 'width': '5rem',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:693:- },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:694:- {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:695:- 'label': 'Subject',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:696:- 'type': 'Data',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:697:- 'key': 'subject',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:698:- 'width': '25rem',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:699:- },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:700:- {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:701:- 'label': 'Status',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:702:- 'type': 'Select',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:703:- 'key': 'status',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:704:- 'width': '8rem',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:705:- },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:706:- {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:707:- 'label': 'Priority',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:708:- 'type': 'Link',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:709:- 'options': 'HD Ticket Priority',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:710:- 'key': 'priority',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:711:- 'width': '10rem',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:712:- },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:713:- {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:714:- 'label': 'Type',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:715:- 'type': 'Link',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:689:+ "label": "#",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:690:+ "type": "Int",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:691:+ "key": "name",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:692:+ "width": "5rem",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:693:+ },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:694:+ {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:695:+ "label": "Subject",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:696:+ "type": "Data",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:697:+ "key": "subject",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:698:+ "width": "25rem",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:699:+ },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:700:+ {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:701:+ "label": "Status",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:702:+ "type": "Select",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:703:+ "key": "status",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:704:+ "width": "8rem",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:705:+ },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:706:+ {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:707:+ "label": "Priority",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:708:+ "type": "Link",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:709:+ "options": "HD Ticket Priority",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:710:+ "key": "priority",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:711:+ "width": "10rem",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:712:+ },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:713:+ {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:714:+ "label": "Type",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:715:+ "type": "Link",
|
Black - Reviewdog:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py#L717
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:717:- 'key': 'ticket_type',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:718:- 'width': '11rem',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:719:- },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:720:- {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:721:- 'label': 'Team',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:722:- 'type': 'Link',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:717:+ "key": "ticket_type",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:718:+ "width": "11rem",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:719:+ },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:720:+ {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:721:+ "label": "Team",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:722:+ "type": "Link",
|
Black - Reviewdog:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py#L724
[black-format] reported by reviewdog 🐶
Raw Output:
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:724:- 'key': 'agent_group',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:725:- 'width': '10rem',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:726:- },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:727:- {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:728:- 'label': "Contact",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:729:- 'type': 'Link',
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:730:- 'key': "contact",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:724:+ "key": "agent_group",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:725:+ "width": "10rem",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:726:+ },
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:727:+ {
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:728:+ "label": "Contact",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:729:+ "type": "Link",
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py:730:+ "key": "contact",
|
Black - Reviewdog
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L10
[eslint] reported by reviewdog 🐶
Insert `⏎··········`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Insert `⏎··········`","line":10,"column":122,"nodeType":null,"messageId":"insert","endLine":10,"endColumn":122,"fix":{"range":[357,357],"text":"\n "}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L20
[eslint] reported by reviewdog 🐶
Replace `·v-for="(filter,·idx)·in·props.filters"·id="filter-list"` with `⏎··············v-for="(filter,·idx)·in·props.filters"⏎··············id="filter-list"⏎·············`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `·v-for=\"(filter,·idx)·in·props.filters\"·id=\"filter-list\"` with `⏎··············v-for=\"(filter,·idx)·in·props.filters\"⏎··············id=\"filter-list\"⏎·············`","line":20,"column":17,"nodeType":null,"messageId":"replace","endLine":20,"endColumn":73,"fix":{"range":[649,705],"text":"\n v-for=\"(filter, idx) in props.filters\"\n id=\"filter-list\"\n "}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L21
[eslint] reported by reviewdog 🐶
Insert `⏎············`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Insert `⏎············`","line":21,"column":67,"nodeType":null,"messageId":"insert","endLine":21,"endColumn":67,"fix":{"range":[783,783],"text":"\n "}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L27
[eslint] reported by reviewdog 🐶
Replace `·:value="filter.field.fieldname"` with `⏎····················:value="filter.field.fieldname"⏎···················`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `·:value=\"filter.field.fieldname\"` with `⏎····················:value=\"filter.field.fieldname\"⏎···················`","line":27,"column":32,"nodeType":null,"messageId":"replace","endLine":27,"endColumn":64,"fix":{"range":[1075,1107],"text":"\n :value=\"filter.field.fieldname\"\n "}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L28
[eslint] reported by reviewdog 🐶
Replace `·@change="(field)·=>·updateFilter(idx,·field)"` with `⏎····················@change="(field)·=>·updateFilter(idx,·field)"⏎·················`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `·@change=\"(field)·=>·updateFilter(idx,·field)\"` with `⏎····················@change=\"(field)·=>·updateFilter(idx,·field)\"⏎·················`","line":28,"column":47,"nodeType":null,"messageId":"replace","endLine":28,"endColumn":93,"fix":{"range":[1188,1234],"text":"\n @change=\"(field) => updateFilter(idx, field)\"\n "}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L31
[eslint] reported by reviewdog 🐶
Replace `·type="select"·:value="filter.operator"` with `⏎····················type="select"⏎····················:value="filter.operator"⏎···················`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `·type=\"select\"·:value=\"filter.operator\"` with `⏎····················type=\"select\"⏎····················:value=\"filter.operator\"⏎···················`","line":31,"column":31,"nodeType":null,"messageId":"replace","endLine":31,"endColumn":70,"fix":{"range":[1327,1366],"text":"\n type=\"select\"\n :value=\"filter.operator\"\n "}}
|
ESLint - Reviewdog
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.community/t5/GitHub-Actions/Maximum-number-of-annotations-that-can-be-created-using-GitHub/m-p/39085
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L32
[eslint] reported by reviewdog 🐶
Replace `(e)·=>·updateFilter(idx,·null,·null,·e.target.value)"·placeholder="Operator"` with `⏎······················(e)·=>·updateFilter(idx,·null,·null,·e.target.value)⏎····················"⏎····················placeholder="Operator"⏎·················`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Replace `(e)·=>·updateFilter(idx,·null,·null,·e.target.value)\"·placeholder=\"Operator\"` with `⏎······················(e)·=>·updateFilter(idx,·null,·null,·e.target.value)⏎····················\"⏎····················placeholder=\"Operator\"⏎·················`","line":32,"column":30,"nodeType":null,"messageId":"replace","endLine":32,"endColumn":106,"fix":{"range":[1444,1520],"text":"\n (e) => updateFilter(idx, null, null, e.target.value)\n \"\n placeholder=\"Operator\"\n "}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L35
[eslint] reported by reviewdog 🐶
Insert `⏎···················`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Insert `⏎···················`","line":35,"column":34,"nodeType":null,"messageId":"insert","endLine":35,"endColumn":34,"fix":{"range":[1636,1636],"text":"\n "}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L36
[eslint] reported by reviewdog 🐶
Insert `⏎···················`
Raw Output:
{"ruleId":"prettier/prettier","severity":2,"message":"Insert `⏎···················`","line":36,"column":69,"nodeType":null,"messageId":"insert","endLine":36,"endColumn":69,"fix":{"range":[1735,1735],"text":"\n "}}
|
Black - Reviewdog
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Semantic Commits
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Semgrep Rules
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L20
[eslint] reported by reviewdog 🐶
Expected a linebreak before this attribute.
Raw Output:
{"ruleId":"vue/first-attribute-linebreak","severity":1,"message":"Expected a linebreak before this attribute.","line":20,"column":18,"nodeType":"VAttribute","messageId":"expected","endLine":20,"endColumn":56,"fix":{"range":[649,650],"text":"\n"}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L27
[eslint] reported by reviewdog 🐶
Expected a linebreak before this attribute.
Raw Output:
{"ruleId":"vue/first-attribute-linebreak","severity":1,"message":"Expected a linebreak before this attribute.","line":27,"column":33,"nodeType":"VAttribute","messageId":"expected","endLine":27,"endColumn":64,"fix":{"range":[1075,1076],"text":"\n"}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L31
[eslint] reported by reviewdog 🐶
Expected a linebreak before this attribute.
Raw Output:
{"ruleId":"vue/first-attribute-linebreak","severity":1,"message":"Expected a linebreak before this attribute.","line":31,"column":32,"nodeType":"VAttribute","messageId":"expected","endLine":31,"endColumn":45,"fix":{"range":[1327,1328],"text":"\n"}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L32
[eslint] reported by reviewdog 🐶
Attribute "placeholder" should go before "@change".
Raw Output:
{"ruleId":"vue/attributes-order","severity":1,"message":"Attribute \"placeholder\" should go before \"@change\".","line":32,"column":84,"nodeType":"VAttribute","endLine":32,"endColumn":106,"fix":{"range":[1435,1520],"text":"placeholder=\"Operator\" @change=\"(e) => updateFilter(idx, null, null, e.target.value)\""}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L35
[eslint] reported by reviewdog 🐶
Expected a linebreak before this attribute.
Raw Output:
{"ruleId":"vue/first-attribute-linebreak","severity":1,"message":"Expected a linebreak before this attribute.","line":35,"column":35,"nodeType":"VAttribute","messageId":"expected","endLine":35,"endColumn":64,"fix":{"range":[1636,1637],"text":"\n"}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L36
[eslint] reported by reviewdog 🐶
Attribute "v-if" should go before ":key".
Raw Output:
{"ruleId":"vue/attributes-order","severity":1,"message":"Attribute \"v-if\" should go before \":key\".","line":36,"column":21,"nodeType":"VAttribute","endLine":36,"endColumn":69,"fix":{"range":[1637,1735],"text":"v-if=\"typeLink.includes(filter.field.fieldtype)\"\n :key=\"filter.field.fieldname\""}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L38
[eslint] reported by reviewdog 🐶
Expected a linebreak before this attribute.
Raw Output:
{"ruleId":"vue/first-attribute-linebreak","severity":1,"message":"Expected a linebreak before this attribute.","line":38,"column":30,"nodeType":"VAttribute","messageId":"expected","endLine":38,"endColumn":36,"fix":{"range":[1902,1903],"text":"\n"}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L38
[eslint] reported by reviewdog 🐶
Attribute ":is" should go before ":value".
Raw Output:
{"ruleId":"vue/attributes-order","severity":1,"message":"Attribute \":is\" should go before \":value\".","line":38,"column":59,"nodeType":"VAttribute","endLine":38,"endColumn":123,"fix":{"range":[1910,1996],"text":":is=\"getValSelect(filter.field.fieldtype, filter.field.options)\" :value=\"filter.value\""}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L49
[eslint] reported by reviewdog 🐶
Expected a linebreak before this attribute.
Raw Output:
{"ruleId":"vue/first-attribute-linebreak","severity":1,"message":"Expected a linebreak before this attribute.","line":49,"column":27,"nodeType":"VAttribute","messageId":"expected","endLine":49,"endColumn":35,"fix":{"range":[2493,2494],"text":"\n"}}
|
ESLint - Reviewdog:
desk/src/components/Filter.vue#L59
[eslint] reported by reviewdog 🐶
Expected a linebreak before this attribute.
Raw Output:
{"ruleId":"vue/first-attribute-linebreak","severity":1,"message":"Expected a linebreak before this attribute.","line":59,"column":21,"nodeType":"VAttribute","messageId":"expected","endLine":59,"endColumn":48,"fix":{"range":[2993,2994],"text":"\n"}}
|