fix: Gross Profit Report with Correct Totals and Gross Margin #45548
+66
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanket322
changed the title
Sanket322
force-pushed
the
gross_profit
branch
from
99745b5 to
ea036d7
Compare
Sanket322
changed the title
ljain112
added
backport version-14-hotfix
vorasmit
reviewed
Jan 29, 2025
vorasmit
reviewed
Jan 29, 2025
vorasmit
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
Co-authored-by: Sanket322 <shahsanket322003.com> (cherry picked from commit aaf720a) # Conflicts: # erpnext/accounts/report/gross_profit/test_gross_profit.py # erpnext/patches.txt
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
Co-authored-by: Sanket322 <shahsanket322003.com> (cherry picked from commit aaf720a)
This was referenced Jan 29, 2025
nabinhait
pushed a commit
that referenced
this pull request
Jan 30, 2025
#45548) (#45598) fix: Gross Profit Report with Correct Totals and Gross Margin (#45548) Co-authored-by: Sanket322 <shahsanket322003.com> (cherry picked from commit aaf720a) Co-authored-by: Sanket Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ticket: Support Ticket - 30225
Before :
The add_total_row option was checked, causing the subtotals to combine, which resulted in an incorrect Selling Amount, Buying Amount, Gross Profit, Gross Profit Percentage.
After :
The total Selling Amount and Buying Amount are now calculated correctly.
The total Gross Profit and Gross Profit Percentage is calculated using a formula.
The add_total_row option was disabled using a patch.