-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fetching items from blanket order to sales/purchase order #45262
Merged
nabinhait
merged 3 commits into
frappe:develop
from
diptanilsaha:fix-blanket-order-zero-item-qty
Jan 17, 2025
Merged
fix: fetching items from blanket order to sales/purchase order #45262
nabinhait
merged 3 commits into
frappe:develop
from
diptanilsaha:fix-blanket-order-zero-item-qty
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabinhait
approved these changes
Jan 17, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
* fix: blanket order with zero item quantity * fix: item quantity validation * refactor: resolve linter issue (cherry picked from commit 98d401b)
ruthra-kumar
added a commit
that referenced
this pull request
Jan 21, 2025
…-45262 fix: fetching items from blanket order to sales/purchase order (backport #45262)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
# [15.49.0](v15.48.4...v15.49.0) (2025-01-22) ### Bug Fixes * Ambiguous column error while creating Sales Return ([#45275](#45275)) ([842d72f](842d72f)) * apply ruff formatter changes ([8e33d93](8e33d93)) * calculate AED exchange rate based on pegged value with USD ([05e4255](05e4255)) * check if tds deducted based on Purchase Taxes and Charges ([#45161](#45161)) ([ade8799](ade8799)) * check if tds deducted based on Purchase Taxes and Charges (backport [#45161](#45161)) ([#45277](#45277)) ([3abca03](3abca03)) * company in quality inspection ([c0cf1fe](c0cf1fe)) * conflict ([bdaf376](bdaf376)) * do not reset picked items ([fd83b52](fd83b52)) * Does not allow to create Sub-Asseblies of Sub Assemblies ([d3c9092](d3c9092)) * ensure multiple PCVs in same fiscal year are considered in patch ([fcd914c](fcd914c)) * fetching items from blanket order to sales/purchase order ([#45262](#45262)) ([7fc19e1](7fc19e1)) * fixed typo in manufacturing settings and field rename ([#45238](#45238)) ([7641627](7641627)) * getting scrap items from sub assemblies by fetching scrap items for parent BOM ([da7b691](da7b691)) * ignore crm deal in tax_rule search filter (backport [#45134](#45134)) ([#45138](#45138)) ([afab5be](afab5be)) * include pos invoice in modifing key for returned item validation ([70ed8b7](70ed8b7)) * linters ([61303db](61303db)) * precision on work order total qty ([#45341](#45341)) ([5346820](5346820)) * **Project:** re-phrase welcome email ([#45175](#45175)) ([c94430a](c94430a)) * round off tax withholding amount ([#45271](#45271)) ([3c10d80](3c10d80)) * sales return for multi-uom ([#45303](#45303)) ([e965b6e](e965b6e)) * set invoice start date to subscription start date (backport [#45342](#45342)) ([#45343](#45343)) ([7045c2c](7045c2c)) * status of the serial no for the raw materials ([d956051](d956051)) * translation fixes ([e4f09ce](e4f09ce)) * updated modified timestamp for stock entry type (backport [#45280](#45280)) ([#45315](#45315)) ([96a3a45](96a3a45)) * use currency defined in plan for subscription invoice ([#45104](#45104)) ([a27eac1](a27eac1)) * use currency defined in plan for subscription invoice (backport [#45104](#45104)) ([#45273](#45273)) ([2c46be4](2c46be4)) * validate linked sales person ([85910ec](85910ec)) ### Features * add option to update modified on communication recieved (backport [#45307](#45307)) ([#45310](#45310)) ([bf8d6ae](bf8d6ae)) * add Syscohada charts of accounts ([2667649](2667649)) * Added valuation of quantity for each age group in stock ageing … (backport [#45076](#45076)) ([#45208](#45208)) ([dd58e4c](dd58e4c)) ### Performance Improvements * Ignore is_opening column in GL Queries ([#45327](#45327)) ([b7de26d](b7de26d)) ### Reverts * avoid change to translatable string ([93e3847](93e3847))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issue #44880 and implemented validation to prevent negative item quantities.