fix: minor refactor based on test cases

frappe · Jan 27, 2025 · 4f6018b · 4f6018b
1 parent 93fab29
commit 4f6018b
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/erpnext/accounts/report/gross_profit/gross_profit.py b/erpnext/accounts/report/gross_profit/gross_profit.py
@@ -198,13 +198,17 @@ def get_data_when_grouped_by_invoice(columns, gross_profit_data, filters, group_
 
 	total_gross_profit = total_base_amount - total_buying_amount
 	data.append(
-		{
-			"sales_invoice": "Total",
-			"selling_amount": total_base_amount,
-			"buying_amount": total_buying_amount,
-			"gross_profit": total_gross_profit,
-			"gross_profit_%": flt((total_gross_profit / total_base_amount) * 100.0, 3),
-		}
+		frappe._dict(
+			{
+				"sales_invoice": "Total",
+				"selling_amount": total_base_amount,
+				"buying_amount": total_buying_amount,
+				"gross_profit": total_gross_profit,
+				"gross_profit_%": flt((total_gross_profit / total_base_amount) * 100.0, 3)
+				if total_base_amount
+				else 0,
+			}
+		)
 	)