Various bug fixes #780
Merged
Various bug fixes #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyo.getValue(*, 'fiscalYear{Start,End}') returns a javascript Date object
that encodes the filcal year as local time (01-01 and 12-31 at midnight).
This date must not be converted to UTC else east timezones will return
the day before (12-31 and 12-30). Use locale time values instead.
When computing the monthly/quaterly/half yearly time periods, correct the
dates in the particular case where the last day of the month is selected
as reference date (yields series 12-31 11-30 10-31 09-30 ...) instead of
(12-31 11-30 10-30 09-30 ...).
In French accounting, multiple root accounts can be of the same type, ensure that reports take all accounts and not only the first one.
18alantom
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[AccountReport] Fix date calculation
fyo.getValue(*, 'fiscalYear{Start,End}') returns a javascript Date object that encodes the filcal year as local time (01-01 and 12-31 at midnight). This date must not be converted to UTC else east timezones will return the day before (12-31 and 12-30). Use locale time values instead.
When computing the monthly/quaterly/half yearly time periods, correct the dates in the particular case where the last day of the month is selected as reference date (yields series 12-31 11-30 10-31 09-30 ...) instead of (12-31 11-30 10-30 09-30 ...).
[fix reports] Allow multiple root account to have the same type
In French accounting, multiple root accounts can be of the same type, ensure that reports take all accounts and not only the first one.