Skip to content

Commit

Permalink
Merge pull request #1057 from stxm/00_NODE_20
Browse files Browse the repository at this point in the history
feat: upgrade nodejs to v20.18.1
  • Loading branch information
akshayitzme authored Jan 3, 2025
2 parents 633aa1b + a958712 commit a2eebba
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '18.19.0'
node-version: '20.18.1'

- name: Set yarn version
run: yarn set version 1.22.18
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '18.19.0'
node-version: '20.18.1'

- name: Set yarn version
run: yarn set version 1.22.18
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '18.19.0'
node-version: '20.18.1'

- name: Checkout Books
uses: actions/checkout@v4
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '18.19.0'
node-version: '20.18.1'

- name: Checkout Books
uses: actions/checkout@v4
Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '18.19.0'
node-version: '20.18.1'

- name: Checkout Books
uses: actions/checkout@v4
Expand Down Expand Up @@ -157,7 +157,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '18.19.0'
node-version: '20.18.1'

- name: Checkout Books
uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '18.19.0'
node-version: '20.18.1'

- name: Set yarn version
run: yarn set version 1.22.18
Expand All @@ -37,7 +37,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v2
with:
node-version: '18.19.0'
node-version: '20.18.1'

- name: Set yarn version
run: yarn set version 1.22.18
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ a local SQLite file as the database.

### Pre-requisites

To get the dev environment up and running you need to first set up Node.js version
16.14.0 and npm. For this, we suggest using
To get the dev environment up and running you need to first set up Node.js `v20.18.1` and npm. For this, we suggest using
[nvm](https://github.com/nvm-sh/nvm#installing-and-updating).

Next, you will need to install [yarn](https://classic.yarnpkg.com/lang/en/docs/install/#mac-stable).
Expand Down
2 changes: 1 addition & 1 deletion build/scripts/helpers.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function getMainProcessCommonConfig(root) {
sourcemap: true,
sourcesContent: false,
platform: 'node',
target: 'node16',
target: 'node20',
external: ['knex', 'electron', 'better-sqlite3', 'electron-store'],
plugins: [excludeVendorFromSourceMap],
write: true,
Expand Down

0 comments on commit a2eebba

Please sign in to comment.