Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(easy-install): read values from env if exists #1611

Merged
merged 3 commits into from
Dec 31, 2024
Merged

fix(easy-install): read values from env if exists #1611

merged 3 commits into from
Dec 31, 2024

Conversation

revant
Copy link
Collaborator

@revant revant commented Dec 26, 2024

@NagariaHussain
Copy link
Member

Will test today 👍

@NagariaHussain NagariaHussain added the add-docs New feature should be have an entry in documentation to increase the discoverability label Dec 27, 2024
@revant
Copy link
Collaborator Author

revant commented Dec 30, 2024

No change in docs. Command remains same, explained here: https://github.com/frappe/bench?tab=readme-ov-file#arguments

@NagariaHussain
Copy link
Member

Cool, will test and merge today 👍

@NagariaHussain NagariaHussain removed the add-docs New feature should be have an entry in documentation to increase the discoverability label Dec 31, 2024
@NagariaHussain
Copy link
Member

I tried running the upgrade command with an updated backup cron string. It did update the env, but not the actual container it seems:

CleanShot 2024-12-31 at 12 34 12@2x

CleanShot 2024-12-31 at 12 34 02@2x

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@NagariaHussain NagariaHussain merged commit 4c6ce63 into frappe:develop Dec 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@revant @NagariaHussain