Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass empty strings to go-imap #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't pass empty strings to go-imap #45

wants to merge 3 commits into from

Conversation

ptrcnull
Copy link
Contributor

@ptrcnull ptrcnull commented Sep 11, 2023 •
edited
Loading

closes #44
closes #46

@ptrcnull ptrcnull marked this pull request as draft September 11, 2023 01:19
@ptrcnull
Copy link
Contributor Author

actually, it still doesn't fix the whole issue:

* 11295 FETCH (UID 31113 FLAGS ( \Seen nonjunk) BODYSTRUCTURE ("text" "html" ("charset" "UTF-8") NIL NIL "quoted-printable" 35910 779 NIL NIL NIL NIL) ENVELOPE ("Sat, 09 Sep 2023 22:12:10 +0000" "[RESOLVED]  (Disk usage)" (("Grafana" NIL "grafana" "ptrc.gay")) (("Grafana" NIL "grafana" "ptrc.gay")) (("Grafana" NIL "grafana" "ptrc.gay")) ((NIL NIL "alerts" "ptrcnull.me")) NIL NIL NIL "<[email protected]>"))

you might notice the FLAGS parenthesized list still having an empty element at the beginning

@ptrcnull ptrcnull force-pushed the fix-empty-flag branch 2 times, most recently from eeda037 to 7e70912 Compare September 11, 2023 02:40
@ptrcnull ptrcnull marked this pull request as ready for review September 11, 2023 02:41
@ptrcnull ptrcnull changed the title Don't pass empty string to go-imap MailboxStatus flags Don't pass empty strings to go-imap Sep 11, 2023
@ptrcnull ptrcnull marked this pull request as draft September 11, 2023 11:19
@ptrcnull
Copy link
Contributor Author

ptrcnull commented Sep 11, 2023 •
edited
Loading

haha, nevermind, this PR somehow makes thunderbird just outright.. not pull messages from the server
it doesn't error out or anything

EDIT: it's just that last commit, apparently...

@ptrcnull
Copy link
Contributor Author

fixed it

@ptrcnull ptrcnull marked this pull request as ready for review September 11, 2023 11:30
@ptrcnull
Copy link
Contributor Author

tested with:

  • Thunderbird 115.2.0
  • aerc 0.15.2
  • K-9 Mail 6.602
  • alps 652ea9c7 ( go-imap v2 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ptrcnull