removed alternative deal function within the Cheatcodes interface
#998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
changed the title
deal function within the Cheatcodes interfacedeal function within the Cheatcodes interface
Evalir
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted that the
dealfunction in the cheatcodes interface allows for modifying ERC-20 token balances. However, based on the current implementation of forge-std, this function isn't directly provided by the VM (which can only change native token balances like ETH). Instead, it's implemented in StdCheats.sol and utilized not through VM calls but directly in test (with support for various ERC standard tokens already added).This clarification is provided to address potential confusion, which I encountered.