Improve app bundle integrity check #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mike-sul
commented
Dec 9, 2024
•
mike-sul
commented
- Unify and simplify implementation of the app installation verification.
- Optionally, check whether an app is installed as part of the command verifying if an app is running.
mike-sul
force-pushed
the
improve-app-bundle-integrity-check
branch
2 times, most recently
from
e60b5c7 to
2758a61
Compare
Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
improve-app-bundle-integrity-check
branch
2 times, most recently
from
da50870 to
9b6de58
Compare
mike-sul
force-pushed
the
improve-app-bundle-integrity-check
branch
from
9b6de58 to
baf6b22
Compare
detsch
reviewed
Dec 11, 2024
cmd/composectl/cmd/ps.go
Outdated
| @@ -63,7 +67,7 @@ func init() { | |||
|
|
|||
| var psCmd = &cobra.Command{ | |||
| Use: "ps", | |||
There was a problem hiding this comment.
Suggested change
| Use: "ps", | |
| Use: "ps [ref]...", |
There was a problem hiding this comment.
OK. However, I think I should fix the "Use" and "Short" for the overall composectl since they are not used correctly (another PR).
detsch
reviewed
Dec 11, 2024
cmd/composectl/cmd/ps.go
Outdated
| @@ -63,7 +67,7 @@ func init() { | |||
|
|
|||
| var psCmd = &cobra.Command{ | |||
| Use: "ps", | |||
| Short: "ps <ref> [<ref>]", | |||
| Short: "ps [<ref> [<ref>]]", | |||
There was a problem hiding this comment.
This is a more standard way to document this kind of parameter, where 0..N refs can be passed
Suggested change
| Short: "ps [<ref> [<ref>]]", | |
| Short: "ps [ref]...", |
detsch
reviewed
Dec 11, 2024
| } | ||
| ) | ||
|
|
||
| func init() { | ||
| opts := psOptions{} | ||
| psCmd.Flags().StringVar(&opts.Format, "format", "table", "Format the output. Values: [table | json]") | ||
| psCmd.Flags().BoolVar(&opts.CheckInstall, "install", true, "Also check if app is installed") |
There was a problem hiding this comment.
I find --install confusing as it might give the idea that something will be installed.
I would rather use --check-installation, unless it is too long.
There was a problem hiding this comment.
I think it is too long. I read it as do "ps --install" command that checks running apps along with their installation. Also, it is in sync what we already have for "check" command.
mike-sul
force-pushed
the
improve-app-bundle-integrity-check
branch
from
baf6b22 to
d718c7c
Compare
detsch
approved these changes
Dec 11, 2024
Use the same function to check whether app in installed for both the "check" and "ps" commands. This check includes: 1. Verification if all app images are present in the docker store. 2. Verification if an app bundle is properly installed in the compose/project directory (all bundle files present and their hashes match the expected hashes). Also, a new flag "--install" was added to the "ps" command to turn on/off the installation check after checking if app is running. By default this check is enabled. Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
improve-app-bundle-integrity-check
branch
from
d718c7c to
ec4dcc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.