-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apps: Add a flag to disable SBOM generation #334
Conversation
@vanmaegima - this seems to work in my factory. You think this will work for the customer request? |
sbom_dst=/archive/sboms/${ct_base}/${ARCH}.spdx.json | ||
mkdir -p $(dirname $sbom_dst) | ||
syft ${ct_base}:$TAG-$ARCH -o spdx-json > $sbom_dst | ||
if [ -z "$DISABLE_SBOM" ] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doanac To implement this a user adds this to the params
block of containers
?
DISABLE_SBOM: "1"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep. i'm testing that now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here it is disabled - https://app.foundries.io/factories/andy-corp/targets/77/
here it is enabled(default) - https://app.foundries.io/factories/andy-corp/targets/78/
@doanac If that is part of the |
This only disables for containers. SBOM generation for Platform is done via Yocto - I'm not sure how you disable that. |
The yocto SPDX can also be disabled but I don't see much benefit in doing it, in the kirkstone branch it also have negative side effects like reducing the sstate-cache reuse. |
Disabling from Yocto is probably not necessary, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Andy Doan <[email protected]>
rebased on master |
No description provided.