Fix/dont set shortlist if none #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't set the `shortlist` attribute in the input json if the `shortlist` input parameter in `None`. Otherwise, the input target json is modified - the `shortlist: None` field is added to it. It is not desirable during the app fetching when the target json serves solely as an input read-only parameter. Signed-off-by: Mike Sul <[email protected]>
mike-sul
force-pushed
the
fix/dont-set-shortlist-if-none
branch
from
2c833db to
64fd39f
Compare
doanac
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set the 'shortlist' attribute in the input JSON if the 'shortlist' input parameter is set to 'None'.Otherwise, the input target JSON will be modified to include the 'shortlist: null' field. This is undesirable during app fetching when the target JSON serves solely as a read-only parameter.
E.g.