Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assemble: Create set out of the target apps #328

Merged
merged 1 commit into from
Mar 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assemble.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,9 +283,9 @@ def check_and_get_fetched_apps_uri(target: FactoryClient.Target, shortlist: [str
x.strip() for x in fetched_apps_str.split(',') if x)
else:
# if `shortlist` is not defined or empty then all target apps were fetched
fetched_apps = [x[0] for x in target.apps()]
fetched_apps = set(app[0] for app in target.apps())

apps_to_fetch = set(shortlist) if shortlist else set(target.apps().keys())
apps_to_fetch = set(shortlist) if shortlist else set(app[0] for app in target.apps())

if fetched_apps.issubset(apps_to_fetch):
# if the previously fetched apps is a sub-set of the apps to be fetched then
Expand Down