helpers: Hack around MEDs/oe-builtin issue #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oe-builtin logic is seeing a CI error like: | Traceback (most recent call last): | File "/script-repo/preload_apps.py", line 14, in <module> | from apps.docker_registry_client import ThirdPartyRegistry | File "/script-repo/apps/docker_registry_client.py", line 18, in <module> | class DockerRegistryClient: | File "/script-repo/apps/docker_registry_client.py", line 19, in DockerRegistryClient | DefaultRegistryHost = 'hub.' + fio_dnsbase() | File "/script-repo/helpers.py", line 123, in fio_dnsbase | parts = urlparse(os.environ["H_RUN_URL"]) | File "/usr/lib/python3.8/os.py", line 675, in __getitem__ | raise KeyError(key) from None | KeyError: 'H_RUN_URL' This is because bitbake isolates the environment that it runs in. There are a couple ways to pass H_RUN_URL in, but they cause a big cache invalidation. The workaround provided here works as long as we don't have a customer on MEDs that does oe-builtin. Signed-off-by: Andy Doan <[email protected]>
camilamacedo86
approved these changes
Feb 28, 2024
MrCry0
approved these changes
Feb 28, 2024
mike-sul
reviewed
Feb 28, 2024
| parts = urlparse(os.environ["H_RUN_URL"]) | ||
| _, base = parts.netloc.split(".", 1) | ||
| return base | ||
| run_url = os.environ.get("H_RUN_URL") |
There was a problem hiding this comment.
Could be os.environ.get("H_RUN_URL", "https://api.foundries.io") too. Or, os.environ.get("H_RUN_URL",os.environ.get("GIT_URL"))
There was a problem hiding this comment.
The giturl but I don't think it gets passed into bitbake does it?
There was a problem hiding this comment.
I see it in the bitbake runs.
GIT_URL=https://source.foundries.io/factories/msul-dev01/lmp-manifest.git
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oe-builtin logic is seeing a CI error like:
| Traceback (most recent call last):
| File "/script-repo/preload_apps.py", line 14, in
| from apps.docker_registry_client import ThirdPartyRegistry
| File "/script-repo/apps/docker_registry_client.py", line 18, in
| class DockerRegistryClient:
| File "/script-repo/apps/docker_registry_client.py", line 19, in DockerRegistryClient
| DefaultRegistryHost = 'hub.' + fio_dnsbase()
| File "/script-repo/helpers.py", line 123, in fio_dnsbase
| parts = urlparse(os.environ["H_RUN_URL"])
| File "/usr/lib/python3.8/os.py", line 675, in getitem
| raise KeyError(key) from None
| KeyError: 'H_RUN_URL'
This is because bitbake isolates the environment that it runs in. There are a couple ways to pass H_RUN_URL in, but they cause a big cache invalidation.
The workaround provided here works as long as we don't have a customer on MEDs that does oe-builtin.