appengine: Check only if app installed and running #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check only if app is installed and running at the "is app running" check at the beginning of each update cycle. Whether app blobs are present&OK or not does NOT impact a properly installed and running app. Moreover, after "is app running" check, the aklite daemon checks whether all enabled apps (including the "reset" apps) are fully fetched. We need this check to make sure a user can switch (turn on/off) apps even in offline mode. Therefore, this change removes the redundant check whether all app blobs are fetched&OK called at the "is app running" check. Signed-off-by: Mike Sul <[email protected]>
|
What are the plans to add this to |
detsch
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check only if app is installed and running at the "is app running" check at the beginning of each update cycle.
Whether app blobs are present&OK or not does NOT impact a properly installed and running app. Moreover, after "is app running" check, the aklite daemon checks whether all enabled apps (including the "reset" apps) are fully fetched. We need this check to make sure a user can switch (turn on/off) apps even in offline mode.
Therefore, this change removes the redundant check whether all app blobs are fetched&OK called at the "is app running" check.