apps: Check if app running before if fetched

Checking whether app is running is faster compared to checking  whether
app is fully fetched. So, let us do the lighter check before the heavy
one; if app is not running aklite attempts to re-fetch and re-install it
anyway.

Signed-off-by: Mike Sul <[email protected]>

src/composeappmanager.cc

@@ -230,20 +230,20 @@ ComposeAppManager::AppsContainer ComposeAppManager::getAppsToUpdate(const Uptane
     }
 
     LOG_DEBUG << app_name << " performing full status check";
-    if (!app_engine_->isFetched({app_name, app_pair.second})) {
-      // an App that is supposed to be installed is not fully installed
-      apps_to_update.insert(app_pair);
-      apps_and_reasons[app_pair.first] = "not fetched";
-      LOG_INFO << app_name << " is not fully fetched; missing blobs will be fetched";
-      continue;
-    }
     if (!app_engine_->isRunning({app_name, app_pair.second})) {
       // an App that is supposed to running is not running
       apps_to_update.insert(app_pair);
       apps_and_reasons[app_pair.first] = "not running";
       LOG_INFO << app_name << " is not installed or not running; will be installed and started";
       continue;
     }
+    if (!app_engine_->isFetched({app_name, app_pair.second})) {
+      // an App that is supposed to be installed is not fully installed
+      apps_to_update.insert(app_pair);
+      apps_and_reasons[app_pair.first] = "not fetched";
+      LOG_INFO << app_name << " is not fully fetched; missing blobs will be fetched";
+      continue;
+    }
   }
 
   return apps_to_update;