Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwanted log #8

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Remove unwanted log #8

merged 1 commit into from
Nov 6, 2023

Conversation

JustinWonjaePark
Copy link
Contributor

@JustinWonjaePark JustinWonjaePark commented Oct 23, 2023 •
edited by soimkim
Loading

Description

Remove unwanted log

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@JustinWonjaePark JustinWonjaePark added the bug fix [PR] Fix the bug label Oct 23, 2023
@JustinWonjaePark JustinWonjaePark self-assigned this Oct 23, 2023
@soimkim
Copy link
Contributor

soimkim commented Oct 27, 2023

check_packaging_files , run_notice_html_checklist 등등 함수가 동작될 때 logger가 제대로 세팅되지 않을 것으로 보입니다.
재검토 부탁드립니다.

@JustinWonjaePark
Remove unwanted log
04a68c3 
Signed-off-by: Wonjae Park <[email protected]>
@JustinWonjaePark
Copy link
Contributor Author

check_packaging_files , run_notice_html_checklist 등등 함수가 동작될 때 logger가 제대로 세팅되지 않을 것으로 보입니다. 재검토 부탁드립니다.

변수 셋팅 후 / 함수들 동작 전으로 logger 초기화 위치 변경하였습니다.

@soimkim soimkim merged commit 2cdce8a into main Nov 6, 2023
4 checks passed
@soimkim soimkim deleted the dev_versionLog branch November 6, 2023 05:31
@soimkim soimkim added chore [PR/Issue] Refactoring, maintenance the code and removed bug fix [PR] Fix the bug labels Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soimkim soimkim Awaiting requested review from soimkim

Assignees

@JustinWonjaePark JustinWonjaePark

Labels
chore [PR/Issue] Refactoring, maintenance the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinWonjaePark @soimkim