Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PROPACK to package index #392

Merged
merged 5 commits into from
Apr 15, 2022
Merged

Add PROPACK to package index #392

merged 5 commits into from
Apr 15, 2022

Conversation

ivan-pi
Copy link
Member

@ivan-pi ivan-pi commented Apr 14, 2022

Addresses a subtask in fortran-lang/webpage#50

Project homepage: http://sun.stanford.edu/~rmunk/PROPACK/

PROPACK was recently added to SciPy as one of the available SVD solvers.

Note pencil-code, Elk, and librsb, are handled in other pull requests.

@ivan-pi ivan-pi requested review from LKedward and kjelljorner April 14, 2022 23:52
Copy link

@kjelljorner kjelljorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I don't really understand why the changes for the related pull requests need to be included in this one. I would rather prefer separate pull requests with the unique changes in each.

@ivan-pi
Copy link
Member Author

ivan-pi commented Apr 15, 2022

That's a valid point. My mind was just not thinking clearly enough to roll back from a new branch...

@LKedward
Copy link
Member

#build_preview

@github-actions
Copy link

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/392/

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks Ivan!

@LKedward LKedward merged commit 53c8b73 into fortran-lang:master Apr 15, 2022
@ivan-pi ivan-pi deleted the propack branch April 15, 2022 10:52
@LKedward
Copy link
Member

#delete_preview

@github-actions
Copy link

The preview build for this PR has now been deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants