-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic Windows support + Tools to build executables from examples #1871
base: master
Are you sure you want to change the base?
Conversation
…n to relay for redirection
…ter done + Print notification about redirecting ports
Update Npcap Module Update Npcap Module Update Update Update Sniff.py to prompt user to install npcap Update Update Setup & Installer Update Update Update sniff requirements Update installer for modules Update split.py Move imports in split.py
Patch Readline Patch Readline Patch Readline Patch Readline
Patch Readline
@p0rtL6 Thanks for this amazing new functionality you submitted! |
My main goal here was to have it possible to build these scripts without python available/installed to run on Windows, mostly for portability during engagements. I understand how the build scripts do not align with your goals here, as it seems you are more focused on the maintenance of the library itself. I am happy to maintain the build scripts and support for Windows on my fork, it may be useful to at least include some information on what might need to be done for Windows support as it seems running the included examples on Windows could be a common use-case. The other changes currently present in this request include minor fixes, some of which provide better support for Windows (e.g. packet redirection for SMB to get examples like ntlmrelayx working), these may be more relevant as they broaden the functionality without adding other "parts" to the project (like a build script). If it's preferred, I can submit each of those changes as separate requests. I'm also working on a branch to expand upon the Kerberos options functionality so that individual flags and encryption type settings can be set in Kerberos requests. In order to generate hex strings for even finer control I've also implemented a new example script to generate those as well. This is all functionality inspired by Orpheus. I'm be interested in any feedback you have about that, but was planning on opening a PR separately for those changes so we can discuss there if needed. |
An installer powershell script (impacket-exe-installer.ps1) has been created to install examples as windows standalone executables. (Line 271 would need to be changed to link to the correct repository/branch if merged)
A few changes to make the examples work on Windows:
I understand these changes are a bit different from the idea behind this project, so I am not sure how relevant these are to be merged. If anything should be changed or updated, or anything else, I will keep an eye on this and respond to messages.