NEW (GithubActions) @W-15362406@: Added PR title enforcement action. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
commented
Apr 19, 2024
| @@ -20,7 +20,7 @@ jobs: | |||
| - name: 'Set up NodeJS' | |||
| uses: actions/setup-node@v4 | |||
| with: | |||
| node-version: 'lts/*' # Node LTS should always be fine. | |||
| node-version: '20.12.1' # Node LTS should always be fine. | |||
There was a problem hiding this comment.
We can revert this next week.
There was a problem hiding this comment.
This workflow should never be run again. So I'm deleting it to prevent that.
| - name: Verify PR Title | ||
| run: echo 'Nope not yet' | ||
| uses: ./github-actions/verify-pr-title |
There was a problem hiding this comment.
Integration of new action.
There was a problem hiding this comment.
Tests basically copy-pasted from the Scanner repo.
There was a problem hiding this comment.
Tests basically copy-pasted from the scanner repo.
There was a problem hiding this comment.
Tests basically copy-pasted from the Scanner repo.
stephen-carter-at-sf
approved these changes
Apr 19, 2024
| * This regex portion matches any string wrapped in parentheses without additional | ||
| * parentheses inside it. | ||
| */ | ||
| const SCOPE_PORTION = '\\([^()]+\\)'; |
There was a problem hiding this comment.
We may or may not even need this for the vs code extension. The scope will probably always just be VSCode Extension. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.