@W-14219242@: Fixing behavioral issues with telemetry. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
commented
Dec 1, 2023
| @@ -79,14 +79,34 @@ export class CoreExtensionService { | |||
| * | |||
| * @returns The {@link TelemetryService} object exported by the Core Extension if available, else null. | |||
| */ | |||
| public static getTelemetryService(): TelemetryService|null { | |||
| public static _getTelemetryService(): CoreTelemetryService|null { | |||
There was a problem hiding this comment.
The leading underscore is a JS social convention indicating that the method should be treated by developers as private even though it's technically public.
| if (CoreExtensionService.initialized) { | ||
| return CoreExtensionService.telemetryService; | ||
| } | ||
| throw new Error(messages.error.coreExtensionServiceUninitialized); | ||
| } | ||
| } | ||
|
|
||
| export class TelemetryService { |
There was a problem hiding this comment.
Moving TelemetryService into core-extension-service.ts allowed me to make it so all telemetry events have to go through this class instead of calling CoreExtensionService._getTelemetryService() directly.
| export class TelemetryService { | ||
| public static sendCommandEvent(key: string, data: Properties): void { | ||
| const coreTelemetryService = CoreExtensionService.getTelemetryService(); | ||
| coreTelemetryService.sendCommandEvent(key, undefined, data); |
There was a problem hiding this comment.
This needed to be coreTelemetryService?.sendCommandEvent, like how it's done in sendException. That error has been corrected in the version that now exists in core-extension-service.ts.
smotwani11
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.