NEW (Extension) @W-17330890@ A4D SFCA Integration - Integrate with UnifiedDiff UI #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - add token to access internal repo
…exCRUDViolation - change imports
…exCRUDViolation - change imports
…ed imports and auths
jag-j
changed the title
jag-j
commented
Jan 21, 2025
| @@ -33,7 +33,9 @@ | |||
| "SFCA" | |||
| ], | |||
| "dependencies": { | |||
| "@salesforce/vscode-service-provider": "^1.3.0-rc.6.2", | |||
There was a problem hiding this comment.
We access the LLM model via this package.
jag-j
commented
Jan 21, 2025
| "cross-spawn": "^7.0.3", | ||
| "einstein-shared": "https://github.com/forcedotcom/salesforcedx-vscode-einstein-shared#semver:0.3.9", |
There was a problem hiding this comment.
This is the shared module repository and since the package cannot be open sourced yet, we depend on it this way.
There was a problem hiding this comment.
When installing our vscode extention… will the new dependency
einstein-shared": "https://github.com/forcedotcom/salesforcedx-vscode-einstein-shared#semver:0.3.9",
get pulled during install or is it installed into the vsix file?
That is... can we even ship this line of code or will it break users during install?
There was a problem hiding this comment.
We can ship with this line of code. This is bundled into the vsix.
jag-j
commented
Jan 21, 2025
| @@ -9,10 +9,14 @@ jobs: | |||
| steps: | |||
| - name: 'Check out the code' | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| token: ${{ secrets.IDEE_GH_TOKEN }} # So we can access internal repo to pull shared ui components | |||
There was a problem hiding this comment.
This lets us run as idee bot user so we can access the internal private repo.
stephen-carter-at-sf
approved these changes
Jan 21, 2025
jfeingold35
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.