Skip to content

Commit

Permalink
fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jag-j committed Sep 18, 2024
1 parent ee3c782 commit ee4ecb2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"cross-spawn": "^7.0.3",
"glob": "^8.0.3",
"globby": "^11.0.0",
"proxyquire": "^2.1.3",
"semver": "^7.5.4"
},
"devDependencies": {
Expand All @@ -58,6 +57,7 @@
"mocha": "^10.1.0",
"nyc": "^15.1.0",
"ovsx": "^0.8.3",
"proxyquire": "^2.1.3",
"sinon": "^15.1.0",
"ts-node": "^10.9.1",
"typescript": "^4.9.3"
Expand Down
1 change: 0 additions & 1 deletion src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ async function _runDfa(context: vscode.ExtensionContext) {
// Default to "Yes" if no choice is made
const rerunChangedOnly = choice == '***Yes***';
if (rerunChangedOnly) {
// Do nothing for now. This will be implemented as part of W-15639759
const deltaRunTargets = DeltaRunFunctions.getDeltaRunTarget(sfgeCachePath, savedFilesCache);
if (deltaRunTargets.length == 0) {
void vscode.window.showInformationMessage('***No local changes found that would change the outcome of previous SFGE full run.***');
Expand Down

0 comments on commit ee4ecb2

Please sign in to comment.