feat!: change-case v2 #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
commented
May 24, 2024
| @@ -1,43 +1,19 @@ | |||
| # check.description | |||
| # flags.changecaseid.summary | |||
There was a problem hiding this comment.
messages are moved to file-per-command like our normal pattern
mshanemc
commented
May 24, 2024
| "wireit": "^0.9.5" | ||
| "@oclif/plugin-command-snapshot": "^5.1.9", | ||
| "@salesforce/cli-plugins-testkit": "^5.3.5", | ||
| "@salesforce/dev-scripts": "^9.1.2", |
There was a problem hiding this comment.
using devScripts removes a lot of devDeps
mshanemc
commented
May 24, 2024
| @@ -25,7 +24,9 @@ export type CheckResult = { | |||
| type: string; | |||
| }; | |||
| export default class Check extends SfCommand<CheckResult> { | |||
| public static readonly summary = messages.getMessage('check.description'); | |||
| public static readonly deprecated = true; | |||
There was a problem hiding this comment.
we don't use this command
mshanemc
commented
May 24, 2024
| } | ||
|
|
||
| this.log(`Release ${closeResult.results[0].id} set to ${status}.`); | ||
| const closeCase = async (status: string, changecaseid: string, conn: Connection): Promise<string[]> => { |
There was a problem hiding this comment.
the new API stops all the implementation steps as part of close endpoint
iowillhoit
reviewed
May 24, 2024
iowillhoit
reviewed
May 24, 2024
iowillhoit
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://salesforce-internal.slack.com/archives/G02K6C90RBJ/p1716552999650839
QA:
I did this one from local CLI. You'll need the tooling releases user, not your normal GUS uers (you can't create a Build)
https://gus.lightning.force.com/lightning/r/Case/500EE00001DVqC6YAL/view
Then take the resulting ID and close
there's a real NUT covering how we use this in CI
@W-15845325@