remove example extension for OFN initializer; use file expand in seeds.rb instead of require_relative #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor changes:
require_relative
, but that wouldn't work when I used my debugger (RubyMine). [probably because seedBank was doing a code_eval, and that was being called from a rake task, and it was being run with the debugger, so the original path wasn't quite what it used to be (pre-seedBank).]I changed it to
File.expand(.....,FILE)
.Both of those are super minor (and (2) will become moot soon). I thought I'd do a pull request since I hadn't talked to you beforehand about changing anything. And I wanted to practice uploading and doing a pull request. (Which apparently I needed, since I first pushed this to the OFN repo! )
You can hold off on pulling these since they're minor and might be moot. Or you can make these same changes in your commits as you do the seedBank work. Doesn't matter on my end.