Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove example extension for OFN initializer; use file expand in seeds.rb instead of require_relative #1

Open
wants to merge 2 commits into
base: data-initialization
Choose a base branch
from

Conversation

weedySeaDragon
Copy link

Two minor changes:

  1. I needed to remove the ".example" extension from the file config\initializers\open_food_network.rb.example file. (I'm sure that just didn't get committed into the branch as you wanted to)
  2. in seeds.rb, I changed the way the path to suburb_seeds.rb is called: it did use a require_relative , but that wouldn't work when I used my debugger (RubyMine). [probably because seedBank was doing a code_eval, and that was being called from a rake task, and it was being run with the debugger, so the original path wasn't quite what it used to be (pre-seedBank).]
    I changed it to File.expand(.....,FILE).

Both of those are super minor (and (2) will become moot soon). I thought I'd do a pull request since I hadn't talked to you beforehand about changing anything. And I wanted to practice uploading and doing a pull request. (Which apparently I needed, since I first pushed this to the OFN repo! )

You can hold off on pulling these since they're minor and might be moot. Or you can make these same changes in your commits as you do the seedBank work. Doesn't matter on my end.

…nged to File.expand (call to suburbs_seed.rb)

(cherry picked from commit 76c3aa1)
pmackay pushed a commit that referenced this pull request May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant