Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UISER-184: Implement separation of chronology and enumeration #353

Merged
merged 29 commits into from
Feb 5, 2025

Conversation

Jack-Golding
Copy link
Contributor

Convert anywhere that templateConfig rules are used into two separate lists for chronology and enumeration rules

Added chronlogy labels field array to ruleset form
Refactored rendering of token info by moving to child component, also renamed props on chronology field component
Refactored label field array into another seperate enumeration field array component
Added template string field to ruleset form, taken from now deprecated labelfieldarray component
Removed now deprecated label field array
Updated conditionals within the ruleset views to use seperated enumeration/chronology rules
Copy link

License CLA Stuck? (Developer should make sure that it is really stuck before clicking)

Copy link

github-actions bot commented Jan 28, 2025

Jest Unit Test Results

  1 files  ± 0   55 suites  +4   1m 54s ⏱️ -1s
392 tests +34  392 ✅ +34  0 💤 ±0  0 ❌ ±0 
425 runs  +35  425 ✅ +35  0 💤 ±0  0 ❌ ±0 

Results for commit facd14d. ± Comparison against base commit 597b5ac.

This pull request removes 50 and adds 84 tests. Note that renamed tests count towards both.
ChronologyField renders a Select for Weekday format ‑ ChronologyField renders a Select for Weekday format
ChronologyField renders the Month day format dropdown with correct options ‑ ChronologyField renders the Month day format dropdown with correct options
ChronologyField renders the Month format dropdown with correct options ‑ ChronologyField renders the Month format dropdown with correct options
ChronologyField renders the Weekday format dropdown with correct options ‑ ChronologyField renders the Weekday format dropdown with correct options
ChronologyField renders the Year format dropdown with correct options ‑ ChronologyField renders the Year format dropdown with correct options
ChronologyField renders the expected label ‑ ChronologyField renders the expected label
ChronologyField renders the expected template tokens label ‑ ChronologyField renders the expected template tokens label
ChronologyField renders the expected template tokens ‑ ChronologyField renders the expected template tokens
ChronologyField renders the expected text ‑ ChronologyField renders the expected text
ChronologyField renders the submit button ‑ ChronologyField renders the submit button
…
ChronologyField with chronology_date templateMetadataRuleFormat Month day format* select choosing Month day format* option  Option  is selected ‑ ChronologyField with chronology_date templateMetadataRuleFormat Month day format* select choosing Month day format* option  Option  is selected
ChronologyField with chronology_date templateMetadataRuleFormat Month day format* select choosing Month day format* option 3 Option 3 is selected ‑ ChronologyField with chronology_date templateMetadataRuleFormat Month day format* select choosing Month day format* option 3 Option 3 is selected
ChronologyField with chronology_date templateMetadataRuleFormat Month day format* select choosing Month day format* option 3rd Option 3rd is selected ‑ ChronologyField with chronology_date templateMetadataRuleFormat Month day format* select choosing Month day format* option 3rd Option 3rd is selected
ChronologyField with chronology_date templateMetadataRuleFormat Month format* select choosing Month format* option  Option  is selected ‑ ChronologyField with chronology_date templateMetadataRuleFormat Month format* select choosing Month format* option  Option  is selected
ChronologyField with chronology_date templateMetadataRuleFormat Month format* select choosing Month format* option 10 Option 10 is selected ‑ ChronologyField with chronology_date templateMetadataRuleFormat Month format* select choosing Month format* option 10 Option 10 is selected
ChronologyField with chronology_date templateMetadataRuleFormat Month format* select choosing Month format* option Oct Option Oct is selected ‑ ChronologyField with chronology_date templateMetadataRuleFormat Month format* select choosing Month format* option Oct Option Oct is selected
ChronologyField with chronology_date templateMetadataRuleFormat Month format* select choosing Month format* option October Option October is selected ‑ ChronologyField with chronology_date templateMetadataRuleFormat Month format* select choosing Month format* option October Option October is selected
ChronologyField with chronology_date templateMetadataRuleFormat Weekday format* select choosing Weekday format* option  Option  is selected ‑ ChronologyField with chronology_date templateMetadataRuleFormat Weekday format* select choosing Weekday format* option  Option  is selected
ChronologyField with chronology_date templateMetadataRuleFormat Weekday format* select choosing Weekday format* option MON Option MON is selected ‑ ChronologyField with chronology_date templateMetadataRuleFormat Weekday format* select choosing Weekday format* option MON Option MON is selected
ChronologyField with chronology_date templateMetadataRuleFormat Weekday format* select choosing Weekday format* option MONDAY Option MONDAY is selected ‑ ChronologyField with chronology_date templateMetadataRuleFormat Weekday format* select choosing Weekday format* option MONDAY Option MONDAY is selected
…

♻️ This comment has been updated with latest results.

Jack-Golding and others added 14 commits January 28, 2025 16:36
Refactored more places in which templateConfig.rules was used, should be all of them now, additional testing and tidy up required
Implemented some performance refactors discussed previously
Seperated out selectification (?) of chronology refdata values
Updated centralised test resources
Everything should be passing now (Yipee)
Very very slight refactor done to pieces preview modal, its out of the scope of this ticket to refactor this, would prefer to add this to tech debt
First run at refactoring chronology field test
Tweaked chronology field test to use .each functions along with stripes-erm-testing helpers
getRulesetFormValues was affected by uiser-182
@Jack-Golding Jack-Golding marked this pull request as ready for review February 3, 2025 11:28
Jack-Golding and others added 7 commits February 4, 2025 13:36
Added test for ChronlogyLabels component
Added tests for enumeration labels component
Added test for enumeration field array component
Added test for chronology fioeld array component
Fixed sonar cloud issue in PiecesPreviewModalForm
Fixed issue with syntax and incorrect implementation of return array
User configured metadata index mapping was weird due to seperation, now filtering so the sv array is just enumeration rules
Added test for RulesetView test
@Jack-Golding Jack-Golding merged commit 1315a44 into master Feb 5, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant