-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UISER-184: Implement separation of chronology and enumeration #353
Conversation
Added chronlogy labels field array to ruleset form
Refactored rendering of token info by moving to child component, also renamed props on chronology field component
Refactored label field array into another seperate enumeration field array component
Added template string field to ruleset form, taken from now deprecated labelfieldarray component
Removed now deprecated label field array
Updated conditionals within the ruleset views to use seperated enumeration/chronology rules
License CLA Stuck? (Developer should make sure that it is really stuck before clicking) |
Jest Unit Test Results 1 files ± 0 55 suites +4 1m 54s ⏱️ -1s Results for commit facd14d. ± Comparison against base commit 597b5ac. This pull request removes 50 and adds 84 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Refactored more places in which templateConfig.rules was used, should be all of them now, additional testing and tidy up required
Implemented some performance refactors discussed previously
Seperated out selectification (?) of chronology refdata values
Updated centralised test resources
Everything should be passing now (Yipee)
Very very slight refactor done to pieces preview modal, its out of the scope of this ticket to refactor this, would prefer to add this to tech debt
First run at refactoring chronology field test
Tweaked chronology field test to use .each functions along with stripes-erm-testing helpers
getRulesetFormValues was affected by uiser-182
Added test for ChronlogyLabels component
Added tests for enumeration labels component
Added test for enumeration field array component
Added test for chronology fioeld array component
Fixed sonar cloud issue in PiecesPreviewModalForm
Fixed issue with syntax and incorrect implementation of return array
User configured metadata index mapping was weird due to seperation, now filtering so the sv array is just enumeration rules
Added test for RulesetView test
Quality Gate passedIssues Measures |
Convert anywhere that templateConfig rules are used into two separate lists for chronology and enumeration rules