Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-597 Commit changes button enabled before preview is populated #670

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Jan 14, 2025

After this PR is merged, the buttons for downloading the preview and the commit button will be synchronized with the display of the preview table, to avoid the possibility of committing or downloading something until the preview is visible.
The state that controls the display of content has been raised several levels up.

Refs: UIBULKED-597

Copy link

github-actions bot commented Jan 14, 2025

Jest Unit Test Statistics

    1 files  ±0    52 suites  ±0   3m 19s ⏱️ +2s
326 tests +2  326 ✔️ +2  0 💤 ±0  0 ±0 
333 runs  +2  333 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit 45a26d3. ± Comparison against base commit fd81279.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 14, 2025

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 45a26d3. ± Comparison against base commit fd81279.

♻️ This comment has been updated with latest results.

@vashjs vashjs marked this pull request as ready for review January 14, 2025 23:50
@vashjs vashjs requested review from UladzislauKutarkin and a team January 14, 2025 23:51
@vashjs vashjs requested review from a team and removed request for a team January 17, 2025 11:24
@vashjs vashjs merged commit 9128145 into master Jan 20, 2025
6 checks passed
@vashjs vashjs deleted the UIBULKED-597 branch January 20, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants