UIBULKED-571 Errors in response to UI calls #661
Conversation
|
@folio-org/fe-tl-reviewers please review |
There was a problem hiding this comment.
A static npm library is better than keeping the code : message mapping in our own code, but only just so. If this information is intended for developers to fix the issue, a lack of an error response from the server is most definitely an issue - but that isn't helped if an error message is contrived by the UI. UI modules should not make up for the shortcomings of backend modules.
FOLIO generally keeps a separation between the UI and the backend via interface - this said, backend modules can change without the UI caring, so long as the same interface is still provided. Now with the static list in place, the UI for Bulk Edit has to concern itself with potential changes. Future developments will see if we can make this functionality more dynamic... until then, here we are.
JohnC-80
dismissed
their stale review
See my comment for the architectural issues in this approach. I can only ask for these aspects of this work to be reconsidered.
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
|
Based on the new requirements, for all non bulk-operation modules to which the UI makes requests, errors should be generated according to the following template:
<module-name> returns status code: <status-code> - <error details>.Since some models do not have a message and the message consists only of a status code, additional logic has been added for such cases. Depending on the specific case, a basic HTTP error will be shown based on the dictionary from
http-status-codeslibrary.Refs: UIBULKED-571