Module evaluation for TCR-52/ui-claims #93
Conversation
|
|
| * [ ] Third party dependencies use an Apache 2.0 compatible license | ||
| - Only the FOLIO dependencies and `typescript` use the Apache license | ||
| - Development dependencies that use MIT license: `babel`, `types`, `typescript-eslint`, `core-js`, `eslint`, `history`, `identity-obj-proxy`, `react`, `redux`, `regenerator-runtime`. | ||
| - The runtime and development dependency `lodash` uses OpenJS Foundation, but includes dependencies from vendors that use other licenses: |
There was a problem hiding this comment.
OpenJS Foundation is the copyright holder, not the license.
The license is in lines 15-32. How does this differ from MIT license that it qualifies for a new license name?
https://github.com/lodash/lodash/blob/4.17.21/LICENSE#L15-L32
| - Only the FOLIO dependencies and `typescript` use the Apache license | ||
| - Development dependencies that use MIT license: `babel`, `types`, `typescript-eslint`, `core-js`, `eslint`, `history`, `identity-obj-proxy`, `react`, `redux`, `regenerator-runtime`. | ||
| - The runtime and development dependency `lodash` uses OpenJS Foundation, but includes dependencies from vendors that use other licenses: | ||
| - `backbone`: Copyright (c) 2010-2016 Jeremy Ashkenas, DocumentCloud |
There was a problem hiding this comment.
This is the copyright holder, not the license.
For the license see
| - The runtime and development dependency `lodash` uses OpenJS Foundation, but includes dependencies from vendors that use other licenses: | ||
| - `backbone`: Copyright (c) 2010-2016 Jeremy Ashkenas, DocumentCloud | ||
| - `firebug-lite`: BSD License | ||
| - `json-js`: no explicit license |
There was a problem hiding this comment.
Line 5 has an explicit license: https://github.com/lodash/lodash/blob/4.17.21/vendor/json-js/json2.js#L5
| - Development dependencies that use MIT license: `babel`, `types`, `typescript-eslint`, `core-js`, `eslint`, `history`, `identity-obj-proxy`, `react`, `redux`, `regenerator-runtime`. | ||
| - The runtime and development dependency `lodash` uses OpenJS Foundation, but includes dependencies from vendors that use other licenses: | ||
| - `backbone`: Copyright (c) 2010-2016 Jeremy Ashkenas, DocumentCloud | ||
| - `firebug-lite`: BSD License |
There was a problem hiding this comment.
Please clarify whether firebug-lite is licensed under GPL license: https://github.com/lodash/lodash/blob/4.17.21/vendor/firebug-lite/src/firebug-lite-debug.js#L18
| - `backbone`: Copyright (c) 2010-2016 Jeremy Ashkenas, DocumentCloud | ||
| - `firebug-lite`: BSD License | ||
| - `json-js`: no explicit license | ||
| - `underscore`: Copyright (c) 2009-2016 Jeremy Ashkenas, DocumentCloud and Investigative |
There was a problem hiding this comment.
This is the copyright holder (missing the second line), not the license.
The license is in lines 4-23 and is likely a well known license: https://github.com/lodash/lodash/blob/4.17.21/vendor/underscore/LICENSE#L4-L23
| * [x] The module doesn't access data in DB schemas other than its own and public | ||
| * [x] Any dependencies, other than on defined interfaces, are declared in the README.md. | ||
| * [x] The module responds with a tenant's content based on x-okapi-tenant header | ||
| * [x] Standard GET `/admin/health` endpoint returning a 200 response |
There was a problem hiding this comment.
How did you manage to get a 200 response from ui-claims for a GET /admin/health request?
There was a problem hiding this comment.
I didn't. Since that was listed in the "Backend" section I checked that in accordance with [x] ~INAPPLICABLE~.
See https://folio-org.atlassian.net/browse/TCR-52